From 3c6801e1e57d689463b8ee9da59b207fbc256416 Mon Sep 17 00:00:00 2001
From: maltayyar2 <M.Altayyar@exp-sa.com>
Date: Thu, 20 Nov 2025 23:18:34 +0300
Subject: [PATCH] fix: Use name attribute instead of string in xpath selector
 for Other Details group

- Add name='other_details_group' to Other Details group in purchase_requisition_custom
- Update xpath selector in purchase_custom_stock to use @name instead of @string
- Fix Odoo validation error for view inheritance
- Ensure proper xpath selector compatibility with Odoo standards
---
 .../purchase_custom_stock/views/purchase_request.xml            | 2 +-
 .../purchase_requisition_custom/views/purchase_request.xml      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/odex25_purchase/purchase_custom_stock/views/purchase_request.xml b/odex25_purchase/purchase_custom_stock/views/purchase_request.xml
index 3ec4cc767..8fd66b4c1 100644
--- a/odex25_purchase/purchase_custom_stock/views/purchase_request.xml
+++ b/odex25_purchase/purchase_custom_stock/views/purchase_request.xml
@@ -54,7 +54,7 @@
                 <xpath expr="//field[@name='use_analytic']" position="attributes">
                     <attribute name="attrs">{'readonly':[('state','!=','draft')]}</attribute>
                 </xpath>
-                <xpath expr="//group[@string='Other Details']" position="after">
+                <xpath expr="//group[@name='other_details_group']" position="after">
                     <group string="Warehouse Management" name="warehouse_management_group">
                         <field name="view_location_id" invisible="1"/>
                         <field name="edit_locations" invisible="1"/>
diff --git a/odex25_purchase/purchase_requisition_custom/views/purchase_request.xml b/odex25_purchase/purchase_requisition_custom/views/purchase_request.xml
index 3da2d4655..472628f07 100644
--- a/odex25_purchase/purchase_requisition_custom/views/purchase_request.xml
+++ b/odex25_purchase/purchase_requisition_custom/views/purchase_request.xml
@@ -89,7 +89,7 @@
                                        attrs="{'readonly':['|',('edit_partner_id' , '=' , False),('state' , '!=' , 'waiting')]}"
                                        help="Suggested vendor for this purchase request"/>
                             </group>
-                            <group string="Other Details">
+                            <group string="Other Details" name="other_details_group">
                                 <field name="use_analytic"/>
                                 <field name="account_analytic_id"
                                        options="{'no_create' : True , 'no_edit' : True ,'no_open' : True}"