Merge pull request #1034 from expsa/property_security

Update rent_payment

odex25_realstate/property_management/models/rent_payment.py

@@ -215,9 +215,7 @@ class RentPayment(models.Model):
         if not vendor_id or not account_id:
             raise UserError(_("Vendor or Account not configured properly in settings."))
 
-        if not payments_to_invoice:
-            raise UserError(_("No eligible payments selected. there are payment not valid conditions"))
-        
+        if  payments_to_invoice:
             vendor_bill = self.env['account.move'].create({
                 'move_type': 'in_invoice',
                 'invoice_date': today_date,  # Set the invoice date,
@@ -229,6 +227,8 @@ class RentPayment(models.Model):
                     'account_id': account_id
                 })],
             })
+        else:
+             raise UserError(_("No eligible payments selected. there are payment not valid conditions"))
         
         for payment in payments_to_invoice:
             payment.invoice_commission_id = vendor_bill.id