diff --git a/odex25_hr/hr_government_relations/models/exit_and_return.py b/odex25_hr/hr_government_relations/models/exit_and_return.py index c46f68b13..9f07cbf46 100644 --- a/odex25_hr/hr_government_relations/models/exit_and_return.py +++ b/odex25_hr/hr_government_relations/models/exit_and_return.py @@ -13,9 +13,7 @@ class hr_exit_return(models.Model): ("draft", "Draft"), ("request", "Employee Request"), ("send", "Direct Manager"), - ("accounting", "Accounting Manager"), ("confirm", "Government Relations"), - ("accounting_final", "Accounting Manager"), ("done", "Approved"), ("refuse", "Refuse") ], default='draft', tracking=True) @@ -107,15 +105,8 @@ class hr_exit_return(models.Model): self.state = 'confirm' else: self.state = 'done' - - def accounting(self): - self.state = 'accounting' - return self._reset_to_action() def financial_manager(self): - self.state = 'accounting_final' - - def accounting_final(self): for item in self: if item.on_employee_fair == False and item.cost > 0: debit_line_vals = { @@ -143,15 +134,9 @@ class hr_exit_return(models.Model): item.account_move_id = move_id.id item.state = 'done' - def refuse(self): self.state = 'refuse' - def _reset_to_action(self): - if not self.env.user.has_group('hr_base.group_account_manager'): - return - return self.env.ref('hr_government_relations.exit_and_return_action').sudo().read()[0] - # overrite unlink function def unlink(self): for i in self: diff --git a/odex25_hr/hr_government_relations/models/request_visa.py b/odex25_hr/hr_government_relations/models/request_visa.py index bdbcf9a61..b13ef8978 100644 --- a/odex25_hr/hr_government_relations/models/request_visa.py +++ b/odex25_hr/hr_government_relations/models/request_visa.py @@ -15,12 +15,10 @@ class hr_request_visa(models.Model): ("draft", "Draft"), ("request", "Employee Request"), ("send", "Direct Manager"), - ("accounting", "Accounting Manager"), ("confirm", "Government Relations"), - ("accounting_final", "Accounting Manager"), - ("done", "Done"), + ("done", "HR Approve"), ("refuse", "Refuse") - ], default='draft', tracking=True) + ], default='draft', ) religion = fields.Selection(selection=[('muslim', 'Muslim'), ('christian', 'Christian'), ('other', 'Other')], default="muslim") from_hr = fields.Boolean() @@ -72,14 +70,10 @@ class hr_request_visa(models.Model): else: self.state = 'draft' - def accounting(self): - self.state = 'accounting' - return self._reset_to_action() - def hr_manager(self): self.state = 'confirm' - def accounting_final(self): + def financial_manager(self): for item in self: if item.cost > 0: debit_line_vals = { @@ -104,18 +98,10 @@ class hr_request_visa(models.Model): item.account_move_id = move_id.id self.state = 'done' - - def financial_manager(self): - self.state = 'accounting_final' def refuse(self): self.state = 'refuse' - - def _reset_to_action(self): - if not self.env.user.has_group('hr_base.group_account_manager'): - return - return self.env.ref('hr_government_relations.request_visa_action').sudo().read()[0] - + def unlink(self): for i in self: if i.state != 'draft': diff --git a/odex25_hr/hr_government_relations/security/hr_government_relations_security.xml b/odex25_hr/hr_government_relations/security/hr_government_relations_security.xml index fbd54182e..e8120b96b 100644 --- a/odex25_hr/hr_government_relations/security/hr_government_relations_security.xml +++ b/odex25_hr/hr_government_relations/security/hr_government_relations_security.xml @@ -58,20 +58,6 @@ - - Accounting Manager: views Exit and Return that needs approval - - ['|',('state','in',['refuse', 'send','accounting_final', 'done']),('employee_id.user_id','=',user.id)] - - - - - Accounting Manager: views Request Visa that needs approval - - ['|',('state','in',['refuse', 'send','accounting_final', 'done']),('employee_id.user_id','=',user.id)] - - - Manager: views Request Visa of all employee diff --git a/odex25_hr/hr_government_relations/views/exit_and_return.xml b/odex25_hr/hr_government_relations/views/exit_and_return.xml index dcbc1af5f..c003a877a 100644 --- a/odex25_hr/hr_government_relations/views/exit_and_return.xml +++ b/odex25_hr/hr_government_relations/views/exit_and_return.xml @@ -18,37 +18,21 @@