From 5bfccdd8e63dce29edf82cdff8a527e8ff3aa977 Mon Sep 17 00:00:00 2001
From: blackbelts <74664702+eslamtalaat74@users.noreply.github.com>
Date: Thu, 26 Jun 2025 14:53:16 +0300
Subject: [PATCH 1/3] HR Advance Payroll ecurity

---
 .../exp_payroll_custom/views/employee_reward_view.xml     | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/odex25_hr/exp_payroll_custom/views/employee_reward_view.xml b/odex25_hr/exp_payroll_custom/views/employee_reward_view.xml
index e59fe0ca3..391f1cce5 100644
--- a/odex25_hr/exp_payroll_custom/views/employee_reward_view.xml
+++ b/odex25_hr/exp_payroll_custom/views/employee_reward_view.xml
@@ -128,13 +128,7 @@
         <menuitem id="employee_reward_menu" name="Employee Reward and Allowances"
                   parent="exp_hr_payroll.menu_hr_payroll_root"
                   action="employee_reward_list_action" sequence="10"
-                  groups=
-                          "hr_base.group_executive_manager,
-                  hr.group_hr_user,
-                  hr_base.group_department_manager,
-                  hr_base.group_division_manager,
-                  hr_base.group_general_manager,
-                  exp_hr_payroll.group_hr_payroll_user"/>
+                  groups="hr_base.group_executive_manager,hr.group_hr_user,hr_base.group_department_manager,hr_base.group_division_manager,hr_base.group_general_manager,exp_hr_payroll.group_hr_payroll_user"/>
 
     </data>
 </odoo>

From 9bf1194d7f03309ed672340b644e210fa43d8e0c Mon Sep 17 00:00:00 2001
From: blackbelts <74664702+eslamtalaat74@users.noreply.github.com>
Date: Sun, 29 Jun 2025 11:10:59 +0300
Subject: [PATCH 2/3] payroll groups

---
 odex25_hr/exp_hr_payroll/views/hr_payslip_views.xml | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/odex25_hr/exp_hr_payroll/views/hr_payslip_views.xml b/odex25_hr/exp_hr_payroll/views/hr_payslip_views.xml
index aed3da416..6650757bf 100644
--- a/odex25_hr/exp_hr_payroll/views/hr_payslip_views.xml
+++ b/odex25_hr/exp_hr_payroll/views/hr_payslip_views.xml
@@ -446,10 +446,7 @@
         <menuitem id="menu_hr_payslip_run"
                   action="action_hr_payslip_run_tree"
                   parent="menu_hr_payroll_root"
-                  groups=
-                  "hr_base.group_executive_manager,
-                  hr_base.group_general_manager,
-                  exp_hr_payroll.group_hr_payroll_user"
+                  groups="hr_base.group_executive_manager,hr_base.group_general_manager,exp_hr_payroll.group_hr_payroll_user"
         />
 
         <!--  Shortcuts -->

From 3ed037ae2a067b4cd50bc3430d6314004a1bcb39 Mon Sep 17 00:00:00 2001
From: blackbelts <74664702+eslamtalaat74@users.noreply.github.com>
Date: Sun, 29 Jun 2025 11:21:33 +0300
Subject: [PATCH 3/3] payroll groups

---
 odex25_hr/exp_payroll_custom/security/security.xml | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/odex25_hr/exp_payroll_custom/security/security.xml b/odex25_hr/exp_payroll_custom/security/security.xml
index 35063d036..6cbfd11c9 100644
--- a/odex25_hr/exp_payroll_custom/security/security.xml
+++ b/odex25_hr/exp_payroll_custom/security/security.xml
@@ -49,12 +49,13 @@
             <field name="model_id" ref="model_hr_payslip"/>
             <field name="domain_force">[(1,'=',1)]</field>
             <field name="groups" eval="[(4, ref('exp_payroll_custom.group_hr_payroll_contributor')),
-                                        (4, ref('hr.group_hr_user')),(4, ref('hr.group_hr_manager')),
+
                                         (4, ref('hr_base.group_general_manager')),
                                         (4, ref('exp_hr_payroll.group_hr_payroll_user')),
                                         (4, ref('hr_base.group_executive_manager')),
 
                                         ]"/>
+<!--            (4, ref('hr.group_hr_manager')),(4, ref('hr.group_hr_user')),-->
         </record>
 
         <record id="hr_payslip_rule_comp_rule" model="ir.rule">