From 67d3535274e5784f2716e176a46bb94f5cea9ac8 Mon Sep 17 00:00:00 2001
From: Mohamed Eltayar <eltayar@MoSalah-MacPro.local>
Date: Thu, 13 Nov 2025 18:55:10 +0300
Subject: [PATCH] fix: remove invalid department_id field from hr.department
 views
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

🚨 **Critical XML Fix**
Fixed ValidationError: الحقل department_id غير موجود في النموذج hr.department

## 🔧 **Problem Fixed**
- Removed invalid department_id field from hr.department form view
- Removed department_id field and grouping from hr.department search view
- hr.department cannot reference itself via department_id field

## 📁 **Files Modified**
- odex25_hr/hr_base/views/hr_base_view.xml: Removed invalid department_id references

## ✅ **Impact**
- Fixes XML validation error during module upgrade
- Maintains proper model field relationships
- Allows successful hr_base module loading

## 🔗 **Related**
Fixes error in PR #5412 - Department display enhancement
---
 odex25_hr/hr_base/views/hr_base_view.xml | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/odex25_hr/hr_base/views/hr_base_view.xml b/odex25_hr/hr_base/views/hr_base_view.xml
index 77abdcc60..1c59322ec 100644
--- a/odex25_hr/hr_base/views/hr_base_view.xml
+++ b/odex25_hr/hr_base/views/hr_base_view.xml
@@ -567,7 +567,6 @@
                     <field name="department_type" required="1"/>
                     <field name="is_branch" string="Is Branch?"/>
                     <field name="branch_name" string="Branch Name" context="{'show_branch_short': True}"/>
-                    <field name="department_id" context="{'show_department_short': True}"/>
                 </xpath>
                 <xpath expr="//field[@name='name']" position="after">
                     <label for="english_name" class="oe_edit_only"/>
@@ -619,12 +618,10 @@
             <field name="arch" type="xml">
                 <xpath expr="//field[@name='name']" position="after">
                     <field name="branch_name" string="Branch" context="{'show_branch_short': True}"/>
-                    <field name="department_id" string="Department" context="{'show_department_short': True}"/>
                 </xpath>
                 <xpath expr="//filter[@name='inactive']" position="after">
                     <separator/>
                     <filter string="Branch" name="group_branch" context="{'group_by':'branch_name', 'show_branch_short': True}"/>
-                    <filter string="Department" name="group_department" context="{'group_by':'department_id', 'show_department_short': True}"/>
                 </xpath>
             </field>
         </record>