From 32f3a858c5ccdf7de756f2b2fafe683b87ce11a0 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Wed, 4 Sep 2024 15:24:54 +0300
Subject: [PATCH 01/23] Update property_conf_views.xml

---
 .../property_management/views/property_conf_views.xml          | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/odex25_realstate/property_management/views/property_conf_views.xml b/odex25_realstate/property_management/views/property_conf_views.xml
index 7761ddd3f..2782df2ec 100644
--- a/odex25_realstate/property_management/views/property_conf_views.xml
+++ b/odex25_realstate/property_management/views/property_conf_views.xml
@@ -16,8 +16,11 @@
                                     <span class="o_form_label">Property Commission Settings</span>
                                     <div class="text-muted">Commission Settings.</div>
                                     <div class="text-muted content-group mt16">
+                                        <label for="commission_percentage">Commission Percentage:</label>
                                         <field class="text-left oe_inline" name="commission_percentage" widget="percentage"/><br/>
+                                        <label for="commission_account_id">Commission Account:</label>
                                         <field class="text-left oe_inline" name="commission_account_id"/><br/>
+                                        <label for="collecting_company_id">Collecting Company:</label>
                                         <field class="text-left oe_inline" name="collecting_company_id"/>
                                     </div>
                                 </div>

From 97d41d24dcd8e3e94ab4f4ee193b5b686e655aae Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 20:59:17 +0300
Subject: [PATCH 02/23] Update property_management_menu

---
 .../views/property_management_menu_view.xml                     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/odex25_realstate/property_management_menu/views/property_management_menu_view.xml b/odex25_realstate/property_management_menu/views/property_management_menu_view.xml
index 25796bcbc..8e3f5168b 100644
--- a/odex25_realstate/property_management_menu/views/property_management_menu_view.xml
+++ b/odex25_realstate/property_management_menu/views/property_management_menu_view.xml
@@ -27,7 +27,7 @@
         <menuitem name="Configuration"
                   id="property_management_conf"
                   parent="property_management_main_menu"
-                  sequence="3"
+                  sequence="3" groups="property_management.group_property_user"
         />
 
         <menuitem name="Report"

From de05146c9dfb02c507eb61664a47f36684fa3820 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:00:02 +0300
Subject: [PATCH 03/23] Update property_management_menu_view.xml

---
 .../views/property_management_menu_view.xml                    | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/odex25_realstate/property_management_menu/views/property_management_menu_view.xml b/odex25_realstate/property_management_menu/views/property_management_menu_view.xml
index 8e3f5168b..b9ac04670 100644
--- a/odex25_realstate/property_management_menu/views/property_management_menu_view.xml
+++ b/odex25_realstate/property_management_menu/views/property_management_menu_view.xml
@@ -27,7 +27,8 @@
         <menuitem name="Configuration"
                   id="property_management_conf"
                   parent="property_management_main_menu"
-                  sequence="3" groups="property_management.group_property_user"
+                  sequence="3" 
+                  groups="property_management.group_property_user"
         />
 
         <menuitem name="Report"

From d64a98068274266ab11b3465c2916bb696e2afb3 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:09:58 +0300
Subject: [PATCH 04/23] Update rental_contract_views

---
 .../views/rental_contract_views.xml                   | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/odex25_realstate/property_management/views/rental_contract_views.xml b/odex25_realstate/property_management/views/rental_contract_views.xml
index f2fb701b5..0fa98481d 100644
--- a/odex25_realstate/property_management/views/rental_contract_views.xml
+++ b/odex25_realstate/property_management/views/rental_contract_views.xml
@@ -42,15 +42,22 @@
                                 type="object"/>
                         <button name="action_confirm" string="Confirm"
                                 states="review"
+                            groups="property_management.group_property_manager"
                                 type="object"/>
                         <button name="action_renew" string="Renew Contract" type="object"
                                 confirm="Are you sure to renew the contract? That is mean you will renew this contract and create new draft one"
                                 class="oe_highlight"
                                 states="confirm"
+                            groups="property_management.group_property_manager"
                         />
                         <button name="action_cancel" string="Cancel"
-                                states="draft,submit"
-                                type="object"/>
+                                states="draft,submit,review"
+                                type="object" groups="property_management.group_property_manager"/>
+                        
+                        <button name="action_draft" string="RE-set To Draft"
+                                states="draft,submit,review"
+                                type="object" groups="property_management.group_property_manager"/>
+                        
                         <field name="state" widget="statusbar"
                                statusbar_visible="draft,submit,confirm,review,close,cancel"/>
                     </header>

From 58fe0ce7ddcd853442fba069c48c8b41aa84f233 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:11:57 +0300
Subject: [PATCH 05/23] Update rental_contract

---
 odex25_realstate/property_management/models/rental_contract.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/odex25_realstate/property_management/models/rental_contract.py b/odex25_realstate/property_management/models/rental_contract.py
index ee22e338a..cbb0e911c 100644
--- a/odex25_realstate/property_management/models/rental_contract.py
+++ b/odex25_realstate/property_management/models/rental_contract.py
@@ -403,6 +403,8 @@ class RentalContract(models.Model):
             self.insurance_amount = (self.insurance_cost / 100.0) * self.cal_rent_amount
         elif self.insurance and self.insurance == 'fixed':
             self.insurance_amount = self.insurance_cost
+    def action_draft(self):
+        self.write({'state': 'draft'})
 
     def action_cancel(self):
         if self.rent_payment_ids:

From 6063604ef62d220b017c012d57015a19bc38daf7 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:12:32 +0300
Subject: [PATCH 06/23] Update property_management_menu_view.xml

---
 .../views/property_management_menu_view.xml                     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/odex25_realstate/property_management_menu/views/property_management_menu_view.xml b/odex25_realstate/property_management_menu/views/property_management_menu_view.xml
index b9ac04670..ef4d258b2 100644
--- a/odex25_realstate/property_management_menu/views/property_management_menu_view.xml
+++ b/odex25_realstate/property_management_menu/views/property_management_menu_view.xml
@@ -28,7 +28,7 @@
                   id="property_management_conf"
                   parent="property_management_main_menu"
                   sequence="3" 
-                  groups="property_management.group_property_user"
+                  groups="property_management.group_property_manager"
         />
 
         <menuitem name="Report"

From 2a38c653a058c6646c707e0b28c311e6fe99fb0c Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:16:08 +0300
Subject: [PATCH 07/23] Update end_rent_views

---
 .../property_management/views/end_rent_views.xml          | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/odex25_realstate/property_management/views/end_rent_views.xml b/odex25_realstate/property_management/views/end_rent_views.xml
index 083694e1c..f6c3a2b21 100644
--- a/odex25_realstate/property_management/views/end_rent_views.xml
+++ b/odex25_realstate/property_management/views/end_rent_views.xml
@@ -12,10 +12,16 @@
                                 type="object"/>
                         <button name="action_done" string="Done"
                                 states="check"
+                                groups="property_management.group_property_manager"
                                 type="object"/>
                         <button name="action_cancel" string="Cancel"
                                 states="draft"
-                                type="object"/>
+                                type="object"
+                                groups="property_management.group_property_manager"/>
+                         <button name="action_draft" string="RE-set To Draft"
+                                states="check"
+                                type="object"
+                                groups="property_management.group_property_manager"/>
                         <field name="state" widget="statusbar"/>
                     </header>
                     <sheet>

From 71541d72a6dd060a07cefd326f7fe2e1293eb9c7 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:17:23 +0300
Subject: [PATCH 08/23] Update end_rental_contract

---
 .../property_management/models/end_rental_contract.py          | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/odex25_realstate/property_management/models/end_rental_contract.py b/odex25_realstate/property_management/models/end_rental_contract.py
index 02a8564b1..f7215346e 100644
--- a/odex25_realstate/property_management/models/end_rental_contract.py
+++ b/odex25_realstate/property_management/models/end_rental_contract.py
@@ -81,6 +81,9 @@ class EndOfRent(models.Model):
     def get_remain_amount(self):
         for rec in self:
             rec.remain_amount = rec.insurance_amount - rec.total_amount
+            
+    def action_draft (self):
+        self.write({'state': 'draft'})
 
     def action_cancel(self):
         if self.state not in ['check', 'done']:

From 6ae2585bade9a853872a38771aeb6a1f781c7deb Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:17:45 +0300
Subject: [PATCH 09/23] Update rental_contract_views.xml

---
 .../property_management/views/rental_contract_views.xml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/odex25_realstate/property_management/views/rental_contract_views.xml b/odex25_realstate/property_management/views/rental_contract_views.xml
index 0fa98481d..2f6d4b9a5 100644
--- a/odex25_realstate/property_management/views/rental_contract_views.xml
+++ b/odex25_realstate/property_management/views/rental_contract_views.xml
@@ -55,7 +55,7 @@
                                 type="object" groups="property_management.group_property_manager"/>
                         
                         <button name="action_draft" string="RE-set To Draft"
-                                states="draft,submit,review"
+                                states="submit,review"
                                 type="object" groups="property_management.group_property_manager"/>
                         
                         <field name="state" widget="statusbar"

From 3ebb97e581f64af9fb069d645eb43d32a6d47cb4 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:37:04 +0300
Subject: [PATCH 10/23] Update transfer_contract_view.xml

---
 .../property_management/views/transfer_contract_view.xml    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/odex25_realstate/property_management/views/transfer_contract_view.xml b/odex25_realstate/property_management/views/transfer_contract_view.xml
index c9f1640e5..d691d2005 100644
--- a/odex25_realstate/property_management/views/transfer_contract_view.xml
+++ b/odex25_realstate/property_management/views/transfer_contract_view.xml
@@ -17,10 +17,10 @@
                         />
 
 
-                        <button name="action_reset" string="Set To Draft" type="object" states="submit,cancel"
+                        <button name="action_reset" groups="property_management.group_property_manager"  string="Set To Draft" type="object" states="submit,review,cancel"
                         />
 
-                        <button name="action_cancel" string="Cancel" type="object" states="submit,review,draft"
+                        <button name="action_cancel" groups="property_management.group_property_manager" string="Cancel" type="object" states="submit,review,draft"
                         />
 
                         <field name="state" widget="statusbar"/>
@@ -108,4 +108,4 @@
 
 
 
-</odoo>
\ No newline at end of file
+</odoo>

From a42cb6491186e70c742e625f0f3af5cd5ac0d2b9 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:37:41 +0300
Subject: [PATCH 11/23] Update rental_contract_views

---
 .../property_management/views/rental_contract_views.xml         | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/odex25_realstate/property_management/views/rental_contract_views.xml b/odex25_realstate/property_management/views/rental_contract_views.xml
index 2f6d4b9a5..9b70a56e9 100644
--- a/odex25_realstate/property_management/views/rental_contract_views.xml
+++ b/odex25_realstate/property_management/views/rental_contract_views.xml
@@ -55,7 +55,7 @@
                                 type="object" groups="property_management.group_property_manager"/>
                         
                         <button name="action_draft" string="RE-set To Draft"
-                                states="submit,review"
+                                states="submit,review,cancel"
                                 type="object" groups="property_management.group_property_manager"/>
                         
                         <field name="state" widget="statusbar"

From ceebb22861501dd21e667c60e825a11a16dc5965 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Thu, 5 Sep 2024 21:38:36 +0300
Subject: [PATCH 12/23] Update end_rent_views.xml

---
 odex25_realstate/property_management/views/end_rent_views.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/odex25_realstate/property_management/views/end_rent_views.xml b/odex25_realstate/property_management/views/end_rent_views.xml
index f6c3a2b21..989612485 100644
--- a/odex25_realstate/property_management/views/end_rent_views.xml
+++ b/odex25_realstate/property_management/views/end_rent_views.xml
@@ -19,7 +19,7 @@
                                 type="object"
                                 groups="property_management.group_property_manager"/>
                          <button name="action_draft" string="RE-set To Draft"
-                                states="check"
+                                states="check,cancel"
                                 type="object"
                                 groups="property_management.group_property_manager"/>
                         <field name="state" widget="statusbar"/>

From 8b2ad6b78b065db1dd92dad40426c610bc901321 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 10:50:18 +0300
Subject: [PATCH 13/23] Update end_rent_views

---
 .../property_management/views/end_rent_views.xml      | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/odex25_realstate/property_management/views/end_rent_views.xml b/odex25_realstate/property_management/views/end_rent_views.xml
index 989612485..d240dd9d5 100644
--- a/odex25_realstate/property_management/views/end_rent_views.xml
+++ b/odex25_realstate/property_management/views/end_rent_views.xml
@@ -160,10 +160,19 @@
                                 type="object"/>
                         <button name="action_done" string="Done"
                                 states="submit"
+                            groups="property_management.group_property_manager"
                                 type="object"/>
+                        
                         <button name="action_cancel" string="Cancel"
-                                states="draft"
+                            groups="property_management.group_property_manager"
+                                states="draft,submit"
                                 type="object"/>
+                        
+                        <button name="action_rest_draft" string="RE-SET To Draft"
+                            groups="property_management.group_property_manager"
+                                states="cancel,submit"
+                                type="object"/>
+                        
                         <field name="state" widget="statusbar"/>
                     </header>
                     <sheet>

From 872af3dfc42ca49ee58dee6f046f69653e1041b1 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 10:53:56 +0300
Subject: [PATCH 14/23] Update end_rental_contract.py

---
 .../property_management/models/end_rental_contract.py           | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/odex25_realstate/property_management/models/end_rental_contract.py b/odex25_realstate/property_management/models/end_rental_contract.py
index f7215346e..04fe6c3f0 100644
--- a/odex25_realstate/property_management/models/end_rental_contract.py
+++ b/odex25_realstate/property_management/models/end_rental_contract.py
@@ -197,7 +197,7 @@ class PropertyManagementMaintenance(models.Model):
     contract_id = fields.Many2one('rental.contract', string="Contract")
     property_id = fields.Many2one('internal.property', string="Property")
     partner_id = fields.Many2one('res.partner', string="Partner",domain=[('is_tenant', '=', True)])
-    vendor_id = fields.Many2one('res.partner', string="Vendor",domain=[('is_tenant', '=', True)])
+    vendor_id = fields.Many2one('res.partner', string="Vendor")
     unit_ids = fields.Many2many('re.unit', string="Unit/Units")
     maintenance_cost = fields.Float(string="Maintenance Cost", compute="_get_total_amount", store=True)
     total_amount = fields.Float(string="Total Amount", compute="_get_total_amount", store=True)

From b80653863ca9f247d64fe92dab32f0db6670179a Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 10:55:05 +0300
Subject: [PATCH 15/23] Update end_rent_views

---
 odex25_realstate/property_management/views/end_rent_views.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/odex25_realstate/property_management/views/end_rent_views.xml b/odex25_realstate/property_management/views/end_rent_views.xml
index d240dd9d5..1b14110ed 100644
--- a/odex25_realstate/property_management/views/end_rent_views.xml
+++ b/odex25_realstate/property_management/views/end_rent_views.xml
@@ -200,8 +200,8 @@
                             <group>
                                 <field name="vendor_id"  attrs="{'invisible':[('renter_invoice', '=', True)],
                                 'required':[('renter_invoice', '=', False)], 'readonly':[('state','!=','draft')]}"/>
-                                <field name="maintenance_cost" invisible="1" readonly="1"/>
-                                <field name="hand_cost" invisible="1" readonly="1"/>
+                                <field name="maintenance_cost" invisible="0" readonly="1"/>
+                                <field name="hand_cost" invisible="0" readonly="1"/>
                                 <field name="total_amount" readonly="1"/>
                                 <field name="company_id" readonly="1"/>
                                 <field name="user_id" readonly="1"/>

From f2f756c46a55c88635ac5c49b740452e6e57fce3 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 11:24:53 +0300
Subject: [PATCH 16/23] Update end_rental_contract.py

---
 .../property_management/models/end_rental_contract.py           | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/odex25_realstate/property_management/models/end_rental_contract.py b/odex25_realstate/property_management/models/end_rental_contract.py
index 04fe6c3f0..145ed0361 100644
--- a/odex25_realstate/property_management/models/end_rental_contract.py
+++ b/odex25_realstate/property_management/models/end_rental_contract.py
@@ -96,6 +96,8 @@ class EndOfRent(models.Model):
                 invoice = self.env['account.move'].sudo().create(invoice_vals).with_user(self.env.uid)
                 rec.invoice_id = invoice.id
                 rec.write({'state': 'done'})
+            elif rec.insurance_amount == 0.0:
+                rec.write({'state': 'done'})
             elif rec.remain_amount < 0.0:
                 invoice_vals = rec._prepare_invoice_values(rec, abs(rec.remain_amount))
                 invoice = self.env['account.move'].sudo().create(invoice_vals).with_user(self.env.uid)

From 01f4841da3e75dd2414a740928eac381a72859f6 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 11:52:24 +0300
Subject: [PATCH 17/23] Update end_rental_contract

---
 .../property_management/models/end_rental_contract.py         | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/odex25_realstate/property_management/models/end_rental_contract.py b/odex25_realstate/property_management/models/end_rental_contract.py
index 145ed0361..36bbd23d4 100644
--- a/odex25_realstate/property_management/models/end_rental_contract.py
+++ b/odex25_realstate/property_management/models/end_rental_contract.py
@@ -216,6 +216,10 @@ class PropertyManagementMaintenance(models.Model):
     invoice_id = fields.Many2one('account.move', string="Invoice")
     request_id = fields.Many2one('sale.order', string="Request Item")
 
+    def action_rest_draft(self):
+        rec.write({'state': 'draft'})
+        
+
     @api.onchange('renter_invoice')
     def rest_values(self):
         if self.partner_id:

From 294a08c4f3d1fcf62f835a1ed2eaaaec482843dd Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 14:11:19 +0300
Subject: [PATCH 18/23] Update rent_payment.py

---
 .../property_management/models/rent_payment.py     | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/odex25_realstate/property_management/models/rent_payment.py b/odex25_realstate/property_management/models/rent_payment.py
index b783a7f64..099f8d153 100644
--- a/odex25_realstate/property_management/models/rent_payment.py
+++ b/odex25_realstate/property_management/models/rent_payment.py
@@ -112,8 +112,7 @@ class RentPayment(models.Model):
         
         if payment.amount>0.00:
             line_invoice.append((0, 0, {
-                'name':'قيمة الإيجار '+' - '+payment.contract_id.name+'- '+self.property_id.name+' - '+self.unit_ids[0].name+' - ' + self.name + ' - ' + payment.code + ' - ' + str(payment.due_date),
-                'price_unit': self.amount,
+                'name': 'قيمة الإيجار ' + ' - ' + str(payment.contract_id.name or '') + ' - ' + str(self.property_id.name or '') + ' - ' + unit_name + ' - ' + str(self.name or '') + ' - ' + str(payment.code or '') + ' - ' + str(payment.due_date or ''),
                 'quantity': 1.0,
                 'account_id': payment.contract_id.revenue_account_id.id,
                 'analytic_account_id': payment.property_id.account_analy_id.id if payment.property_id.account_analy_id else False,
@@ -121,7 +120,7 @@ class RentPayment(models.Model):
             }))
         if payment.water_cost>0.00:
             line_invoice.append((0, 0, {
-                'name': 'تكلفة المياه'+' -'+self.name + ' - '+payment.contract_id.name +' - ' +self.property_id.name+' - '+self.unit_ids[0].name+' - ' + payment.code + ' - ' + str(payment.due_date),
+                'name': 'قيمة الإيجار ' + ' - ' + str(payment.contract_id.name or '') + ' - ' + str(self.property_id.name or '') + ' - ' + unit_name + ' - ' + str(self.name or '') + ' - ' + str(payment.code or '') + ' - ' + str(payment.due_date or ''),
                 'price_unit':self.water_cost,
                 'quantity': 1.0,
                 'account_id': payment.contract_id.revenue_account_id.id,
@@ -130,7 +129,7 @@ class RentPayment(models.Model):
             }),)
         if payment.service_cost>0.00:
             line_invoice.append((0, 0, {
-                'name':'قيمة الخدمات'+' - '+ self.name+' - '+payment.contract_id.name + ' - '+self.property_id.name+' - '+self.unit_ids[0].name+' - ' + payment.code + ' - ' + str(payment.due_date),
+                'name': 'قيمة الإيجار ' + ' - ' + str(payment.contract_id.name or '') + ' - ' + str(self.property_id.name or '') + ' - ' + unit_name + ' - ' + str(self.name or '') + ' - ' + str(payment.code or '') + ' - ' + str(payment.due_date or ''),
                 'price_unit': self.service_cost,
                 'quantity': 1.0,
                 'analytic_account_id': payment.property_id.account_analy_id.id if payment.property_id.account_analy_id else False,
@@ -139,7 +138,7 @@ class RentPayment(models.Model):
             }))
         if payment.amount==0.00 and payment.service_cost==0.00 and payment.water_cost==0.00:
             line_invoice.append((0, 0, {
-                'name':self.name + ' - ' +payment.contract_id.name + ' - '+self.property_id.name+' - '+self.unit_ids[0].name+' - '+payment.code + ' - ' + str(payment.due_date),
+                'name': 'قيمة الإيجار ' + ' - ' + str(payment.contract_id.name or '') + ' - ' + str(self.property_id.name or '') + ' - ' + unit_name + ' - ' + str(self.name or '') + ' - ' + str(payment.code or '') + ' - ' + str(payment.due_date or ''),
                 'price_unit':self.total_amount,
                 'quantity': 1.0,
                 'analytic_account_id': payment.property_id.account_analy_id.id if payment.property_id.account_analy_id else False,
@@ -212,11 +211,16 @@ class RentPayment(models.Model):
         today_date = datetime.today().strftime('%Y-%m-%d')
         name = (_('Commission for selected payments'))
 
+        # Ensure vendor and account are valid
+        if not vendor_id or not account_id:
+            raise UserError(_("Vendor or Account not configured properly in settings."))
+
         if not payments_to_invoice:
             raise UserError(_("No eligible payments selected. there are payment not valid conditions"))
         
         vendor_bill = self.env['account.move'].create({
             'move_type': 'in_invoice',
+            'invoice_date': today_date,  # Set the invoice date,
             'partner_id': vendor_id,
             'invoice_line_ids': [(0, 0, {
                 'name': name+' - '+str(today_date),

From 350480db3eda66eeec53810a6514b679f511cde7 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 14:12:24 +0300
Subject: [PATCH 19/23] Update rent_payment.py

---
 odex25_realstate/property_management/models/rent_payment.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/odex25_realstate/property_management/models/rent_payment.py b/odex25_realstate/property_management/models/rent_payment.py
index 099f8d153..c0595dcb2 100644
--- a/odex25_realstate/property_management/models/rent_payment.py
+++ b/odex25_realstate/property_management/models/rent_payment.py
@@ -107,6 +107,7 @@ class RentPayment(models.Model):
     def _prepare_invoice_values(self, payment, amount):
         
         self.renter_id.property_account_receivable_id = payment.contract_id.debit_account_id.id
+        unit_name = self.unit_ids[0].name if self.unit_ids else ''  # Check if unit_ids is not empty
         line_invoice=[]
         line_journal = []
         

From 8de38dcb6400f163069118d202fdb9941c85f8c8 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 14:12:53 +0300
Subject: [PATCH 20/23] Update ir_sequence_data

---
 .../property_management/data/ir_sequence_data.xml    | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/odex25_realstate/property_management/data/ir_sequence_data.xml b/odex25_realstate/property_management/data/ir_sequence_data.xml
index ab6ae24ad..5a08e141e 100644
--- a/odex25_realstate/property_management/data/ir_sequence_data.xml
+++ b/odex25_realstate/property_management/data/ir_sequence_data.xml
@@ -94,6 +94,18 @@
                     record.action_validate2()
             </field>
         </record>
+         <record id="custom_invoice_action_server" model="ir.actions.server">
+            <field name="name">Create Commission Vendor Invoice</field>
+            <field name="model_id" ref="property_management.model_rent_payment"/>
+            <field name="binding_model_id" ref="property_management.model_rent_payment"/>
+            <field name="binding_view_types">list</field>
+            <field name="state">code</field>
+            <field name="code">
+                for record in records:
+                    record.create_vendor_bill_for_payments()
+            </field>
+        </record>
+        
         <record id="custom_invoice_action_server" model="ir.actions.server">
             <field name="name">Create Commission Vendor Invoice</field>
             <field name="model_id" ref="property_management.model_rent_payment"/>

From 8c6d5b0f34c52b2dd77e87b55b874a5223e6fa82 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 15:13:55 +0300
Subject: [PATCH 21/23] Update end_rental_contract

---
 .../models/end_rental_contract.py             | 37 +++++++++++++++++--
 1 file changed, 34 insertions(+), 3 deletions(-)

diff --git a/odex25_realstate/property_management/models/end_rental_contract.py b/odex25_realstate/property_management/models/end_rental_contract.py
index 36bbd23d4..53fc6aee7 100644
--- a/odex25_realstate/property_management/models/end_rental_contract.py
+++ b/odex25_realstate/property_management/models/end_rental_contract.py
@@ -42,6 +42,7 @@ class EndOfRent(models.Model):
     invoice_id = fields.Many2one('account.move', string="Invoice")
 
     def _prepare_out_refund_invoice_values(self, end, amount):
+        self.contract_id.partner_id.property_account_receivable_id = end.contract_id.debit_account_id.id
         invoice_vals = {
             'ref': end.name,
             'move_type': 'out_refund',
@@ -54,12 +55,19 @@ class EndOfRent(models.Model):
                 'name': end.name + ' - ' + str(end.date),
                 'price_unit': amount,
                 'quantity': 1.0,
+                'account_id':  end.contract_id.accrued_account_id.id,
 
             })],
+            'line_ids': [(0, 0, {'account_id': end.contract_id.accrued_account_id.id, 'debit': 0.0, 'credit': amount,
+                                 'name': end.name + ' - ' + str(end.date),
+                                 'quantity': 1}),
+                         (0, 0,
+                          {'account_id': end.contract_id.debit_account_id.id, 'debit': amount, 'credit': 0.0, 'quantity': 1})]
         }
         return invoice_vals
 
     def _prepare_invoice_values(self, end, amount):
+        self.contract_id.partner_id.property_account_receivable_id = end.contract_id.revenue_account_id.id
         invoice_vals = {
             'ref': end.name,
             'move_type': 'out_invoice',
@@ -74,6 +82,11 @@ class EndOfRent(models.Model):
                 'quantity': 1.0,
 
             })],
+         'line_ids': [(0, 0, {'account_id': end.contract_id.debit_account_id.id, 'debit': 0.0, 'credit': amount,
+                                 'name': end.name + ' - ' + str(end.date),
+                                 'quantity': 1}),
+                         (0, 0,
+                          {'account_id': end.contract_id.revenue_account_id.id, 'debit': amount, 'credit': 0.0, 'quantity': 1})]
         }
         return invoice_vals
 
@@ -91,16 +104,34 @@ class EndOfRent(models.Model):
 
     def action_done(self):
         for rec in self:
-            if rec.remain_amount > 0.0:
+            if (rec.remain_amount > 0.0) or  (rec.remain_amount > 0.0 and rec.maintenance):
                 invoice_vals = rec._prepare_out_refund_invoice_values(rec, rec.remain_amount)
                 invoice = self.env['account.move'].sudo().create(invoice_vals).with_user(self.env.uid)
+                # Get the ID of the second line
+                line_id = invoice.invoice_line_ids[1].id
+                commands = [(2, line_id, 0)]
+                invoice.write({'invoice_line_ids': commands})
                 rec.invoice_id = invoice.id
                 rec.write({'state': 'done'})
-            elif rec.insurance_amount == 0.0:
+            elif (rec.insurance_amount == 0.0 or rec.remain_amount==0.0) and !rec.maintenance:
                 rec.write({'state': 'done'})
-            elif rec.remain_amount < 0.0:
+            elif (rec.insurance_amount == 0.0 or rec.remain_amount==0.0) and rec.maintenance:
                 invoice_vals = rec._prepare_invoice_values(rec, abs(rec.remain_amount))
                 invoice = self.env['account.move'].sudo().create(invoice_vals).with_user(self.env.uid)
+                # Get the ID of the second line
+                line_id = invoice.invoice_line_ids[1].id
+                commands = [(2, line_id, 0)]
+                invoice.write({'invoice_line_ids': commands})
+                rec.invoice_id = invoice.id
+                rec.write({'state': 'done'})
+                
+            elif (rec.remain_amount < 0.0)  or (rec.remain_amount<0.0 and rec.maintenance):
+                invoice_vals = rec._prepare_invoice_values(rec, abs(rec.remain_amount))
+                invoice = self.env['account.move'].sudo().create(invoice_vals).with_user(self.env.uid)
+                # Get the ID of the second line
+                line_id = invoice.invoice_line_ids[1].id
+                commands = [(2, line_id, 0)]
+                invoice.write({'invoice_line_ids': commands})
                 rec.invoice_id = invoice.id
                 rec.write({'state': 'done'})
             if rec.contract_state == 'before':

From 3e7599bced77c26b3735706140802750ca654ec2 Mon Sep 17 00:00:00 2001
From: zainab2097 <149927291+zainab2097@users.noreply.github.com>
Date: Sun, 8 Sep 2024 15:19:41 +0300
Subject: [PATCH 22/23] Update rental_contract.py

---
 .../property_management/models/rental_contract.py             | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/odex25_realstate/property_management/models/rental_contract.py b/odex25_realstate/property_management/models/rental_contract.py
index cbb0e911c..74700a161 100644
--- a/odex25_realstate/property_management/models/rental_contract.py
+++ b/odex25_realstate/property_management/models/rental_contract.py
@@ -239,8 +239,8 @@ class RentalContract(models.Model):
                 'rent_type': self.rent_type.id,
                 'rent_amount': self.rent_amount,
                 'water_cost': self.water_cost,
-                'services_cost': self.service_amount,
-                'service_cost': self.service_cost,
+                'service_amount': self.service_amount,  # Correct field for service amount
+                'service_cost': self.service_cost,  # Correct field for service cost
                 'previous_contract_id': self.id,
                 'insurance_cost': self.insurance_cost,
                 'insurance_amount': self.insurance_amount,

From 45016f3de67ad4a328c676d44ce5879060d29900 Mon Sep 17 00:00:00 2001
From: zainab8585 <zeinabeng900@gmail.com>
Date: Sun, 8 Sep 2024 14:29:53 +0200
Subject: [PATCH 23/23] [ADD\ADD security+custom task

---
 .../property_management/data/ir_sequence_data.xml         | 6 +++---
 .../property_management/models/end_rental_contract.py     | 2 +-
 .../models/property_management_conf.py                    | 8 --------
 .../property_management/models/rent_payment.py            | 1 -
 4 files changed, 4 insertions(+), 13 deletions(-)

diff --git a/odex25_realstate/property_management/data/ir_sequence_data.xml b/odex25_realstate/property_management/data/ir_sequence_data.xml
index 5a08e141e..073f94823 100644
--- a/odex25_realstate/property_management/data/ir_sequence_data.xml
+++ b/odex25_realstate/property_management/data/ir_sequence_data.xml
@@ -84,7 +84,7 @@
 
         <!-- Add server action to check from due date -->
         <record id="custom_action_server" model="ir.actions.server">
-            <field name="name">Due Date Server Action</field>
+            <field name="name">Due Date</field>
             <field name="model_id" ref="property_management.model_rent_payment"/>
             <field name="binding_model_id" ref="property_management.model_rent_payment"/>
             <field name="binding_view_types">list</field>
@@ -106,7 +106,7 @@
             </field>
         </record>
         
-        <record id="custom_invoice_action_server" model="ir.actions.server">
+        <record id="custom_create_invoice_action_server" model="ir.actions.server">
             <field name="name">Create Commission Vendor Invoice</field>
             <field name="model_id" ref="property_management.model_rent_payment"/>
             <field name="binding_model_id" ref="property_management.model_rent_payment"/>
@@ -114,7 +114,7 @@
             <field name="state">code</field>
             <field name="code">
                 for record in records:
-                    record.create_vendor_bill_for_payments()
+                    record.action_invoice()
             </field>
         </record>
         <!-- End -->
diff --git a/odex25_realstate/property_management/models/end_rental_contract.py b/odex25_realstate/property_management/models/end_rental_contract.py
index 53fc6aee7..66ba4d6f7 100644
--- a/odex25_realstate/property_management/models/end_rental_contract.py
+++ b/odex25_realstate/property_management/models/end_rental_contract.py
@@ -113,7 +113,7 @@ class EndOfRent(models.Model):
                 invoice.write({'invoice_line_ids': commands})
                 rec.invoice_id = invoice.id
                 rec.write({'state': 'done'})
-            elif (rec.insurance_amount == 0.0 or rec.remain_amount==0.0) and !rec.maintenance:
+            elif (rec.insurance_amount == 0.0 or rec.remain_amount==0.0) and not rec.maintenance:
                 rec.write({'state': 'done'})
             elif (rec.insurance_amount == 0.0 or rec.remain_amount==0.0) and rec.maintenance:
                 invoice_vals = rec._prepare_invoice_values(rec, abs(rec.remain_amount))
diff --git a/odex25_realstate/property_management/models/property_management_conf.py b/odex25_realstate/property_management/models/property_management_conf.py
index a47ea261f..511ed1d6e 100644
--- a/odex25_realstate/property_management/models/property_management_conf.py
+++ b/odex25_realstate/property_management/models/property_management_conf.py
@@ -3,14 +3,6 @@
 
 from odoo import models, fields, api, exceptions, tools, _
 
-class Company(models.Model):
-    _inherit = 'res.company'
-    
-    commission_percentage = fields.Float(string='Commission Percentage', help="The commission percentage.")
-    commission_account_id = fields.Many2one('account.account', string='Commission Account', help="The account used to record commissions.")
-    collecting_company_id = fields.Many2one('res.partner', string='Collecting Company', help="The company responsible for collecting the commission.")
-    
-
 class ResConfigSettings(models.TransientModel):
     _inherit = 'res.config.settings'
 
diff --git a/odex25_realstate/property_management/models/rent_payment.py b/odex25_realstate/property_management/models/rent_payment.py
index c0595dcb2..5ae370a4b 100644
--- a/odex25_realstate/property_management/models/rent_payment.py
+++ b/odex25_realstate/property_management/models/rent_payment.py
@@ -203,7 +203,6 @@ class RentPayment(models.Model):
     def create_vendor_bill_for_payments(self):
         active_ids = self._context.get('active_ids', [])
         # action = self.env['rent.payment'].browse(context.get('active_ids', []))
-        # payments_to_invoice = action.filtered(lambda p: p.state == 'paid' and p.collected_from_company and not p.invoice_commission_id)
         payments_to_invoice = self.env['rent.payment'].browse(active_ids).filtered(
         lambda p: p.state == 'paid' and p.collected_from_company and not p.invoice_commission_id)
         vendor_id = int(self.env['ir.config_parameter'].sudo().get_param('property_management.collecting_company_id'))