From 7d34e58749947b7298ab25c024f3bb4c20d23e81 Mon Sep 17 00:00:00 2001
From: younes <Y.Ketfi_cherif@exp-sa.com>
Date: Mon, 24 Nov 2025 08:33:55 +0100
Subject: [PATCH] [IMP] odex_benefit: Add group access restrictions to Family
 Expense menus and buttons

---
 .../odex_benefit/security/ir.model.access.csv  |  3 ++-
 .../odex_benefit/views/actions_and_menus.xml   |  2 +-
 .../odex_benefit/views/family_expense_view.xml | 18 ++++++++++--------
 3 files changed, 13 insertions(+), 10 deletions(-)

diff --git a/odex25_ensan/odex_benefit/security/ir.model.access.csv b/odex25_ensan/odex_benefit/security/ir.model.access.csv
index 007479da1..57fedfe01 100644
--- a/odex25_ensan/odex_benefit/security/ir.model.access.csv
+++ b/odex25_ensan/odex_benefit/security/ir.model.access.csv
@@ -114,7 +114,8 @@ access_education_result,access_education_result,model_education_result,,1,1,1,1
 access_study_material,access_study_material,model_study_material,,1,1,1,1
 access_suspend_reason,access_suspend_reason,model_suspend_reason,,1,1,1,1
 access_suspend_reason_wizard,access_suspend_reason_wizard,model_suspend_reason_wizard,,1,1,1,1
-access_confirm_benefit_expense,access_confirm_benefit_expense,model_confirm_benefit_expense,base.group_user,1,1,1,1
+access_expense_family_services_manager,access_expense_family_services_manager,model_confirm_benefit_expense,odex_benefit.group_family_services_manager,1,1,1,1
+access_expense_benefit_manager,access_expense_benefit_manager,model_confirm_benefit_expense,odex_benefit.group_benefit_manager,1,1,1,1
 access_branch_settings,access_branch_settings,model_branch_settings,base.group_user,1,1,1,1
 access_services_settings,access_services_settings,model_services_settings,base.group_user,1,1,1,1
 access_rent_lines,access_rent_lines,model_rent_lines,base.group_user,1,1,1,1
diff --git a/odex25_ensan/odex_benefit/views/actions_and_menus.xml b/odex25_ensan/odex_benefit/views/actions_and_menus.xml
index 391a2d059..04d12e363 100644
--- a/odex25_ensan/odex_benefit/views/actions_and_menus.xml
+++ b/odex25_ensan/odex_benefit/views/actions_and_menus.xml
@@ -1045,7 +1045,7 @@
         <menuitem id="education_exam_type_menu" name="Exams Type"
             parent="education_main_menu" action="education_exam_type_action" sequence="9"/>
         <menuitem id="menu_confirm_benefit_expense" name="Benefit Expense Flow" parent="odex_benefit.benefit_services"
-            action="action_confirm_benefit_expense" sequence="11"/>
+            action="action_confirm_benefit_expense" sequence="11" groups="odex_benefit.group_family_services_manager,odex_benefit.group_benefit_manager"/>
         <menuitem id="menu_family_bank_report_root"
               name="Family Bank Report"
               parent="account.menu_finance_payables"
diff --git a/odex25_ensan/odex_benefit/views/family_expense_view.xml b/odex25_ensan/odex_benefit/views/family_expense_view.xml
index 87a566fd8..173045e64 100644
--- a/odex25_ensan/odex_benefit/views/family_expense_view.xml
+++ b/odex25_ensan/odex_benefit/views/family_expense_view.xml
@@ -46,28 +46,29 @@
                            statusbar_visible="draft,calculated,accounting_approve,assistant_general_manager,confirm"/>
 
                     <button name="action_calculate" string="Calculate"
+                            groups="odex_benefit.group_family_services_manager"
                             type="object" states="draft" class="btn btn-info"/>
 
                     <button string="Confirm" type="object" name="action_assistant_manager" class="oe_highlight"
-                            states="calculated"/>
+                            states="calculated" groups="odex_benefit.group_family_services_manager"/>
                     <button string="Withdraw" type="object" name="action_reset_to_draft" class="btn btn-danger"
-                            states="calculated"/>
+                            states="calculated" groups="odex_benefit.group_family_services_manager"/>
                     <button string="Recalculate" name="action_recalculate" class="btn btn-info"
-                            type="object" states="calculated"/>
+                            type="object" states="calculated" groups="odex_benefit.group_family_services_manager"/>
 
                     <button string="Confirm" type="object" name="action_accounting_approve" class="oe_highlight"
                             states="assistant_general_manager"
-                            groups="odex25_account_payment_fix.group_depart_manager"/>
+                            groups="odex_benefit.group_benefit_manager"/>
                     <button string="Reset" type="object" name="action_reset_to_draft" class="btn btn-danger"
                             states="assistant_general_manager"
-                            groups="odex25_account_payment_fix.group_depart_manager"/>
+                            groups="odex_benefit.group_benefit_manager"/>
 
                     <button string="Accounting Transfer" type="object" name="action_accounting_transfer"
-                            class="oe_highlight"
+                            class="oe_highlight" groups="odex_benefit.group_family_services_manager"
                             attrs="{'invisible': ['|','|',('state', '!=', 'accounting_approve'),('payment_order_id','!=',False),('move_id','!=',False)]}"
                     />
                     <button string="Reset" type="object" name="action_reset_to_draft" class="btn btn-danger"
-                            states="accounting_approve"/>
+                            states="accounting_approve" groups="odex_benefit.group_family_services_manager"/>
                 </header>
                 <sheet>
                     <div class="oe_button_box" name="button_box">
@@ -354,7 +355,8 @@
                             </field>
                         </page>
                         <page string="Return Lines" attrs="{'invisible': [('is_return_calculation', '=', False)]}">
-                            <field name="return_expense_line_ids"  widget="many2many" domain="[('id', 'in', line_domain_ids)]"
+                            <field name="return_expense_line_ids" widget="many2many"
+                                   domain="[('id', 'in', line_domain_ids)]"
                                    attrs="{'readonly':[('state', '!=', 'draft')]}">
                                 <tree>
                                     <field name="family_id"/>