From 776336b0e26f263168376ac611c45e2400948e50 Mon Sep 17 00:00:00 2001
From: Abdurrahman Saber <a.saber@odex.sa>
Date: Sat, 1 Nov 2025 13:18:29 +0200
Subject: [PATCH 1/3] [IMP] exp_official_mission: adjust approval process

---
 odex25_hr/exp_official_mission/models/hr_official_mission.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/odex25_hr/exp_official_mission/models/hr_official_mission.py b/odex25_hr/exp_official_mission/models/hr_official_mission.py
index bd9ffd281..f1386731c 100644
--- a/odex25_hr/exp_official_mission/models/hr_official_mission.py
+++ b/odex25_hr/exp_official_mission/models/hr_official_mission.py
@@ -564,6 +564,7 @@ class HrOfficialMission(models.Model):
     
     def accounting_manager(self):
         # self.chick_employee_ids()
+        self = self.sudo()
         self.employee_ids.chick_not_overtime()
         self.employee_ids.compute_Training_cost_emp()
         self.employee_ids.write({'status': 'approved'})
@@ -573,7 +574,7 @@ class HrOfficialMission(models.Model):
 
     def accounting_manager_refused(self):
         for rec in self:
-            rec.refused()
+            rec.sudo().refused()
 
     # Refuse For The Direct Manager Only
     def direct_manager_refused(self):
@@ -641,6 +642,7 @@ class HrOfficialMission(models.Model):
 
     def approve(self):
         # check if there is dealing with financial
+        self = self.sudo()
         self.employee_ids.chick_not_overtime()
         if self.employee_ids and self.mission_type.related_with_financial:
             # move amounts to journal entries

From 34bccc0445d89176d02bc3bd97c840f8b668dc79 Mon Sep 17 00:00:00 2001
From: Abdurrahman Saber <a.saber@odex.sa>
Date: Sun, 2 Nov 2025 15:05:09 +0200
Subject: [PATCH 2/3] [IMP] hr_government_relations, exp_ticket_request: add
 accounting approva

---
 .../exp_ticket_request/models/hr_ticketing.py | 10 +++++-
 .../security/ir.model.access.csv              |  7 +++-
 .../views/hr_ticketing_view.xml               | 18 ++++++----
 .../models/exit_and_return.py                 | 18 +++++++---
 .../models/request_visa.py                    | 16 ++++++---
 .../security/ir.model.access.csv              |  5 +++
 .../views/exit_and_return.xml                 | 36 +++++++++++++------
 .../views/request_visa.xml                    | 23 +++++++++---
 8 files changed, 100 insertions(+), 33 deletions(-)

diff --git a/odex25_hr/exp_ticket_request/models/hr_ticketing.py b/odex25_hr/exp_ticket_request/models/hr_ticketing.py
index fcab91928..2644d3742 100644
--- a/odex25_hr/exp_ticket_request/models/hr_ticketing.py
+++ b/odex25_hr/exp_ticket_request/models/hr_ticketing.py
@@ -15,9 +15,11 @@ class HrTicketing(models.Model):
     STATE_SELECTION = [
         ('draft', _('Draft')),
         ('submit', _('Direct Manager')),
+        ('accounting', _('Accounting Manager')),
         ('review', _('Government Relations')),
         ('confirm', _('HR Manager')),
-        ('done', _('Financial Manager')),
+        ('accounting_final', _('Accounting Manager')),
+        ('done', _('Done')),
         ('refuse', _('Refused')),
         #   ('cancelled', _('Cancelled')),
     ]
@@ -93,11 +95,17 @@ class HrTicketing(models.Model):
         self.write({'state': 'submit'})
 
     def review(self):
+        self.write({'state': 'accounting'})
+
+    def accounting(self):
         self.write({'state': 'review'})
 
     def confirm(self):
         self.write({'state': 'confirm'})
 
+    def accounting_final(self):
+        self.write({'state': 'accounting_final'})
+
     def action_done(self):
         if self.cost_of_tickets > 0:
             debit_line_vals = {
diff --git a/odex25_hr/exp_ticket_request/security/ir.model.access.csv b/odex25_hr/exp_ticket_request/security/ir.model.access.csv
index b1a73c0d9..63bd00089 100644
--- a/odex25_hr/exp_ticket_request/security/ir.model.access.csv
+++ b/odex25_hr/exp_ticket_request/security/ir.model.access.csv
@@ -7,4 +7,9 @@ access_hr_airline_hr,hr.airline.hr.manager,model_hr_airline,hr.group_hr_manager,
 access_airline_agent,airline.agent,model_airline_agent,base.group_user,1,0,0,0
 access_airline_agent_hr,airline.agent.manager,model_airline_agent,hr.group_hr_manager,1,1,1,1
 access_hr_airline_city_user,hr_airline_city_user,model_hr_airline_city,base.group_user,1,0,0,0
-access_hr_airline_city_manager,hr_airline_city_manager,model_hr_airline_city,hr.group_hr_manager,1,1,1,1
\ No newline at end of file
+access_hr_airline_city_manager,hr_airline_city_manager,model_hr_airline_city,hr.group_hr_manager,1,1,1,1
+access_hr_ticket_request_accounting,hr.ticket.request.accounting,model_hr_ticket_request,hr_base.group_account_manager,1,1,1,1
+access_hr_ticket_request_type_accounting,hr.ticket.request.type.accounting,model_hr_ticket_request_type,hr_base.group_account_manager,1,1,1,1
+access_hr_airline_accounting,hr.airline.accounting,model_hr_airline,hr_base.group_account_manager,1,1,1,1
+access_hr_airline_city_accounting,hr.airline.city.accounting,model_hr_airline_city,hr_base.group_account_manager,1,1,1,1
+access_airline_agent_accounting,airline.agent.accounting,model_airline_agent,hr_base.group_account_manager,1,1,1,1
\ No newline at end of file
diff --git a/odex25_hr/exp_ticket_request/views/hr_ticketing_view.xml b/odex25_hr/exp_ticket_request/views/hr_ticketing_view.xml
index 8d5c5760f..c0214df69 100644
--- a/odex25_hr/exp_ticket_request/views/hr_ticketing_view.xml
+++ b/odex25_hr/exp_ticket_request/views/hr_ticketing_view.xml
@@ -20,20 +20,24 @@
 
                         <button name="review" states="submit" string="Direct Manager" type="object" class="oe_highlight"
                                 groups="hr_base.group_division_manager"/>
-                        <button name="refuse" states="submit" string="Refuse" type="object" class="oe_highlight"
-                                groups="hr_base.group_division_manager"/>
+                        
+                        <button name="accounting" states="accounting" string="Accounting Manager" type="object" class="oe_highlight"
+                                groups="hr_base.group_account_manager"/>
 
                         <button name="confirm" states="review" string="Government Relations" type="object"
                                 class="oe_highlight"
                                 groups="hr_base.group_government_relations"/>
-                        <button name="refuse" states="review" string="Refuse" type="object" class="oe_highlight"
-                                groups="hr_base.group_government_relations"/>
 
-                        <button name="action_done" states="confirm" string="HR Manager" type="object"
+                        <button name="accounting_final" states="confirm" string="HR Manager" type="object"
                                 class="oe_highlight"
                                 groups="hr.group_hr_manager"/>
-                        <button name="refuse" states="confirm" string="Refuse" type="object" class="oe_highlight"
-                                groups="hr.group_hr_manager"/>
+                                
+                        <button name="action_done" states="accounting_final" string="Financial Manager" type="object"
+                                class="oe_highlight"
+                                groups="hr_base.group_account_manager"/>
+                        
+                        <button name="refuse" states="submit,accounting_final,confirm,review,accounting" string="Refuse" type="object" class="oe_highlight"
+                                groups="hr.group_hr_manager,hr_base.group_government_relations,hr_base.group_account_manager,hr_base.group_division_manager"/>
 
                         <button name="re_draft" string="Re-Draft" type="object" class="oe_highlight"
                                 states="refuse,done"
diff --git a/odex25_hr/hr_government_relations/models/exit_and_return.py b/odex25_hr/hr_government_relations/models/exit_and_return.py
index ccc6e4795..ee8736a37 100644
--- a/odex25_hr/hr_government_relations/models/exit_and_return.py
+++ b/odex25_hr/hr_government_relations/models/exit_and_return.py
@@ -13,7 +13,9 @@ class hr_exit_return(models.Model):
         ("draft", "Draft"),
         ("request", "Employee Request"),
         ("send", "Direct Manager"),
+        ("accounting", "Accounting Manager"),
         ("confirm", "Government Relations"),
+        ("accounting_final", "Accounting Manager"),
         ("done", "Approved"),
         ("refuse", "Refuse")
     ], default='draft', tracking=True)
@@ -88,7 +90,7 @@ class hr_exit_return(models.Model):
         for item in self:
             if item.account_move_id:
                 if item.account_move_id.state == 'draft':
-                    item.account_move_id.state = 'canceled'
+                    item.account_move_id.button_cancel()
                     item.account_move_id = False
                     self.state = 'draft'
                 else:
@@ -105,8 +107,14 @@ class hr_exit_return(models.Model):
             self.state = 'confirm'
         else:
             self.state = 'done'
+    
+    def accounting(self):
+        self.state = 'accounting'
 
     def financial_manager(self):
+        self.state = 'accounting_final'
+
+    def accounting_final(self):
         for item in self:
             if item.on_employee_fair == False and item.cost > 0:
                 debit_line_vals = {
@@ -129,12 +137,12 @@ class hr_exit_return(models.Model):
                        'ref': 'Exit and Return',
                        'line_ids': [(0, 0, debit_line_vals), (0, 0, credit_line_vals)],
                        'res_model': 'hr.exit.return',
-                       'res_id': self.id
+                       'res_id': item.id
                    })
-                   self.account_move_id = move_id.id
-
-        self.state = 'done'
+                   item.account_move_id = move_id.id
 
+            item.state = 'done'
+        
     def refuse(self):
         self.state = 'refuse'
 
diff --git a/odex25_hr/hr_government_relations/models/request_visa.py b/odex25_hr/hr_government_relations/models/request_visa.py
index 50c1f2c31..dda6c831d 100644
--- a/odex25_hr/hr_government_relations/models/request_visa.py
+++ b/odex25_hr/hr_government_relations/models/request_visa.py
@@ -15,10 +15,12 @@ class hr_request_visa(models.Model):
         ("draft", "Draft"),
         ("request", "Employee Request"),
         ("send", "Direct Manager"),
+        ("accounting", "Accounting Manager"),
         ("confirm", "Government Relations"),
-        ("done", "HR Approve"),
+        ("accounting_final", "Accounting Manager"),
+        ("done", "Done"),
         ("refuse", "Refuse")
-    ], default='draft', )
+    ], default='draft', tracking=True)
     religion = fields.Selection(selection=[('muslim', 'Muslim'), ('christian', 'Christian'), ('other', 'Other')],
                                 default="muslim")
     from_hr = fields.Boolean()
@@ -70,10 +72,13 @@ class hr_request_visa(models.Model):
             else:
                 self.state = 'draft'
 
+    def accounting(self):
+        self.state = 'accounting'
+
     def hr_manager(self):
         self.state = 'confirm'
 
-    def financial_manager(self):
+    def accounting_final(self):
         for item in self:
             if item.cost > 0:
                 debit_line_vals = {
@@ -95,10 +100,13 @@ class hr_request_visa(models.Model):
                     'ref': 'Exit and Return',
                     'line_ids': [(0, 0, debit_line_vals), (0, 0, credit_line_vals)]
                 })
-                self.account_move_id = move_id.id
+                item.account_move_id = move_id.id
 
         self.state = 'done'
 
+    def financial_manager(self):
+        self.state = 'accounting_final'
+
     def refuse(self):
         self.state = 'refuse'
 
diff --git a/odex25_hr/hr_government_relations/security/ir.model.access.csv b/odex25_hr/hr_government_relations/security/ir.model.access.csv
index 69f981daa..7d8ab48d1 100644
--- a/odex25_hr/hr_government_relations/security/ir.model.access.csv
+++ b/odex25_hr/hr_government_relations/security/ir.model.access.csv
@@ -9,3 +9,8 @@ hr_request_visa_emp,hr.request.visa.emp,model_hr_request_visa,base.group_user,1,
 hr_request_visa_managr,hr.request.visa.manger,model_hr_request_visa,hr_base.group_division_manager,1,1,1,1
 hr_request_visa_hr,hr.request.visa.hr,model_hr_request_visa,hr.group_hr_user,1,1,1,1
 hr_request_visa_gov,hr.request.visa.gov,model_hr_request_visa,hr_base.group_government_relations,1,1,1,1
+
+access_hr_exit_return_accounting,hr.exit.return.accounting,model_hr_exit_return,hr_base.group_account_manager,1,1,1,1
+access_hr_renew_official_paper_accounting,hr.renew.official.paper.accounting,model_hr_renew_official_paper,hr_base.group_account_manager,1,1,1,1
+access_hr_official_paper_line_accounting,hr.official.paper.line.accounting,model_hr_official_paper_line,hr_base.group_account_manager,1,1,1,1
+access_hr_request_visa_accounting,hr.request.visa.accounting,model_hr_request_visa,hr_base.group_account_manager,1,1,1,1
\ No newline at end of file
diff --git a/odex25_hr/hr_government_relations/views/exit_and_return.xml b/odex25_hr/hr_government_relations/views/exit_and_return.xml
index c003a877a..cc194b2cb 100644
--- a/odex25_hr/hr_government_relations/views/exit_and_return.xml
+++ b/odex25_hr/hr_government_relations/views/exit_and_return.xml
@@ -18,21 +18,37 @@
 
                         <button string="Direct Manager" name="send" type="object" class="oe_highlight" states="request"
                                 groups="hr_base.group_division_manager"/>
+                                
+                        <button string="Accounting Manager" name="accounting" type="object" class="oe_highlight" states="send"
+                                groups="hr_base.group_account_manager"/>
+                            
+                        <button string="Government Relations" name="hr_manager" type="object" class="oe_highlight"
+                            states="accounting"
+                            groups="hr_base.group_government_relations"/>
+                        
+                            
+                        <button string="HR Manager" name="financial_manager" class="oe_highlight" type="object"
+                            states="confirm"
+                            groups="hr.group_hr_user,hr.group_hr_manager"/>
+                            
+                        <button string="Accounting Manager" name="accounting_final" type="object" class="oe_highlight"
+                            states="accounting_final"
+                            groups="hr_base.group_account_manager"/>
+
+                        <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="accounting"
+                                groups="hr_base.group_government_relations"/>
+                        <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="accounting_final"
+                                groups="hr_base.group_account_manager"/>
                         <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="request"
                                 groups="hr_base.group_division_manager"/>
-
-                        <button string="Government Relations" name="hr_manager" type="object" class="oe_highlight"
-                                states="send"
-                                groups="hr_base.group_government_relations"/>
                         <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="send"
-                                groups="hr_base.group_government_relations"/>
-                        <button string="HR Manager" name="financial_manager" class="oe_highlight" type="object"
-                                states="confirm"
-                                groups="hr.group_hr_user, hr.group_hr_manager"/>
+                                groups="hr_base.group_account_manager"/>
+                        <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="confirm"
+                                groups="hr.group_hr_user,hr.group_hr_manager"/>
+                                
                         <button string="Re-draft" name="draft" type="object" class="oe_highlight" states="refuse,done"
                                 groups="hr.group_hr_user" confirm="Are you sure to Reset To Draft This Record?"/>
-                        <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="confirm"
-                                groups="hr.group_hr_user, hr.group_hr_manager"/>
+                        
                         <field name="state" widget="statusbar"/>
 
                     </header>
diff --git a/odex25_hr/hr_government_relations/views/request_visa.xml b/odex25_hr/hr_government_relations/views/request_visa.xml
index 096124b57..ef93ddf69 100644
--- a/odex25_hr/hr_government_relations/views/request_visa.xml
+++ b/odex25_hr/hr_government_relations/views/request_visa.xml
@@ -21,18 +21,31 @@
                         <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="request"
                                 groups="hr_base.group_division_manager"/>
 
-                        <button string="Government Relations" name="hr_manager" type="object" class="oe_highlight"
-                                states="send"
-                                groups="hr_base.group_government_relations"/>
+                        <button string="Accounting Manager" name="accounting" type="object" class="oe_highlight" states="send"
+                                groups="hr_base.group_account_manager"/>
+
                         <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="send"
+                                groups="hr_base.group_account_manager"/>
+
+                        <button string="Government Relations" name="hr_manager" type="object" class="oe_highlight"
+                                states="accounting"
                                 groups="hr_base.group_government_relations"/>
+                        <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="accounting"
+                                groups="hr_base.group_government_relations"/>
+
                         <button string="HR Manager" name="financial_manager" class="oe_highlight" type="object"
                                 states="confirm"
                                 groups="hr.group_hr_user, hr.group_hr_manager"/>
-                        <button string="Re-draft" name="draft" type="object" class="oe_highlight" states="refuse,done"
-                                groups="hr.group_hr_user" confirm="Are you sure to Reset To Draft This Record?"/>
                         <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="confirm"
                                 groups="hr.group_hr_user, hr.group_hr_manager"/>
+                        
+                        <button string="Accounting Manager" name="accounting_final" type="object" class="oe_highlight" states="accounting_final"
+                                groups="hr_base.group_account_manager"/>
+                        <button string="Refuse" name="refuse" type="object" class="oe_highlight" states="accounting_final"
+                                groups="hr_base.group_account_manager"/>
+                        
+                        <button string="Re-draft" name="draft" type="object" class="oe_highlight" states="refuse,done"
+                                groups="hr.group_hr_user" confirm="Are you sure to Reset To Draft This Record?"/>
                         <field name="state" widget="statusbar"/>
 
                     </header>

From 891bd1bac308d5c30dbb8afe3fd574f8bb9c4d2c Mon Sep 17 00:00:00 2001
From: Abdurrahman Saber <a.saber@odex.sa>
Date: Sun, 2 Nov 2025 15:14:34 +0200
Subject: [PATCH 3/3] [IMP] hr_government_relations, exp_ticket_request: add
 accounting approva

---
 odex25_hr/exp_official_mission/models/hr_official_mission.py | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/odex25_hr/exp_official_mission/models/hr_official_mission.py b/odex25_hr/exp_official_mission/models/hr_official_mission.py
index f1386731c..bd9ffd281 100644
--- a/odex25_hr/exp_official_mission/models/hr_official_mission.py
+++ b/odex25_hr/exp_official_mission/models/hr_official_mission.py
@@ -564,7 +564,6 @@ class HrOfficialMission(models.Model):
     
     def accounting_manager(self):
         # self.chick_employee_ids()
-        self = self.sudo()
         self.employee_ids.chick_not_overtime()
         self.employee_ids.compute_Training_cost_emp()
         self.employee_ids.write({'status': 'approved'})
@@ -574,7 +573,7 @@ class HrOfficialMission(models.Model):
 
     def accounting_manager_refused(self):
         for rec in self:
-            rec.sudo().refused()
+            rec.refused()
 
     # Refuse For The Direct Manager Only
     def direct_manager_refused(self):
@@ -642,7 +641,6 @@ class HrOfficialMission(models.Model):
 
     def approve(self):
         # check if there is dealing with financial
-        self = self.sudo()
         self.employee_ids.chick_not_overtime()
         if self.employee_ids and self.mission_type.related_with_financial:
             # move amounts to journal entries