From 6a2a93e0f61bcc38faad2dfcf337ed6df6c2598a Mon Sep 17 00:00:00 2001
From: Mohamed Eltayar <eltayar@MoSalah-MacPro.local>
Date: Thu, 13 Nov 2025 14:58:29 +0300
Subject: [PATCH] fix: correct XPath selectors in HR department tree and search
 views

- Fixed tree view XPath from 'name' to 'display_name' (matches Odoo 14 standard)
- Fixed search view groupby filter position to use 'inactive' filter reference
- Ensures proper inheritance of hr.department views
- Resolves XML validation error during module upgrade

Files modified:
- odex25_hr/hr_base/views/hr_base_view.xml

Fixes XPath validation error in hr_department tree view inheritance
---
 odex25_hr/hr_base/views/hr_base_view.xml | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/odex25_hr/hr_base/views/hr_base_view.xml b/odex25_hr/hr_base/views/hr_base_view.xml
index d969d23ab..058a10f98 100644
--- a/odex25_hr/hr_base/views/hr_base_view.xml
+++ b/odex25_hr/hr_base/views/hr_base_view.xml
@@ -601,7 +601,7 @@
             <field name="model">hr.department</field>
             <field name="inherit_id" ref="hr.view_department_tree"/>
             <field name="arch" type="xml">
-                <xpath expr="//field[@name='name']" position="after">
+                <xpath expr="//field[@name='display_name']" position="after">
                     <field name="branch_name" string="Branch" context="{'show_branch_short': True}"/>
                 </xpath>
             </field>
@@ -616,7 +616,8 @@
                 <xpath expr="//field[@name='name']" position="after">
                     <field name="branch_name" string="Branch" context="{'show_branch_short': True}"/>
                 </xpath>
-                <xpath expr="//group" position="inside">
+                <xpath expr="//filter[@name='inactive']" position="after">
+                    <separator/>
                     <filter string="Branch" name="group_branch" context="{'group_by':'branch_name', 'show_branch_short': True}"/>
                 </xpath>
             </field>