From ffb831c195efe7b3efe83698d3c7c948d6ce09f7 Mon Sep 17 00:00:00 2001
From: Abdurrahman Saber <a.saber@odex.sa>
Date: Wed, 19 Nov 2025 15:14:47 +0400
Subject: [PATCH] [FIX] hr_contract_custom, exp_official_mission: give account
 manager access to contracts, check record field value after creation

---
 odex25_hr/exp_official_mission/models/hr_official_mission.py | 5 ++---
 odex25_hr/hr_contract_custom/security/ir_rules.xml           | 3 ++-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/odex25_hr/exp_official_mission/models/hr_official_mission.py b/odex25_hr/exp_official_mission/models/hr_official_mission.py
index 030c9bf4c..599761d82 100644
--- a/odex25_hr/exp_official_mission/models/hr_official_mission.py
+++ b/odex25_hr/exp_official_mission/models/hr_official_mission.py
@@ -135,11 +135,10 @@ class HrOfficialMission(models.Model):
 
     @api.model
     def create(self, vals):
-        if self.process_type == 'mission':
+        new_record = super(HrOfficialMission, self).create(vals)
+        if new_record.process_type == 'mission':
             seq = self.env['ir.sequence'].next_by_code('hr.official.mission') or '/'
             vals['reference'] = seq
-        new_record = super(HrOfficialMission, self).create(vals)
-
         return new_record
 
     #########################################
diff --git a/odex25_hr/hr_contract_custom/security/ir_rules.xml b/odex25_hr/hr_contract_custom/security/ir_rules.xml
index a24368e5f..d84db4231 100644
--- a/odex25_hr/hr_contract_custom/security/ir_rules.xml
+++ b/odex25_hr/hr_contract_custom/security/ir_rules.xml
@@ -48,7 +48,8 @@
            <field name="model_id" ref="model_hr_contract" />
            <field name="domain_force">[(1 ,'=', 1)]</field>
            <field name="groups"
-            eval="[(4, ref('hr.group_hr_manager')),
+            eval="[(4, ref('hr_base.group_account_manager')),
+                   (4, ref('hr.group_hr_manager')),
                    (4, ref('hr.group_hr_user')),
                    (4, ref('hr_base.group_general_manager')),]"/>
         </record>