**المشكلة:**
Field show_add_benefit_button used in attrs.invisible but missing from view
ValidationError during module upgrade
**الحل:**
إضافة <field name="show_add_benefit_button" invisible="1"/> في tree view
**السبب:**
الـ commit السابق (2bc13b62) لم يتم دمجه في PR #5384
Synced with latest dev_odex25_ensan (2e3d0238) on Wed Nov 12 13:45:50 +03 2025
**المشكلة:**
- تم إضافة widget='section_and_note_one2many'
- تم إضافة editable='bottom'
- تم إضافة <control> section
- هذا منع فتح wizard form وجعل التحرير inline
**الحل:**
- إزالة widget='section_and_note_one2many'
- إزالة editable='bottom'
- إزالة <control> section
- الرجوع للكود الأصلي قبل 5 مساءً يوم 11-11
**النتيجة:**
- زر 'إضافة بند' الآن يفتح wizard form كما كان سابقاً ✅
Synced with dev_odex25_ensan on Wed Nov 12 13:35:10 +03 2025
- Changed && to && in isEditable logic (line 213)
- Fixes XMLSyntaxError: xmlParseEntityRef: no name
Synced with dev_odex25_ensan on Wed Nov 12 05:40:15 +03 2025
- Removed form mode check - buttons now editable in draft state
- Moved code badge to top-right corner (absolute positioning)
- Smaller badge size (14px, compact padding)
- No longer blocks form width
Synced with dev_odex25_ensan on Wed Nov 12 05:10:51 +03 2025
**Problem:**
- Code field (<h1>) was always visible, even when empty
- Wasted vertical space at top of form during record creation
- Not professional appearance with empty heading
**Solution:**
- Code field now HIDDEN until generated (when code is empty/False)
- After "تأكيد البيانات" (Confirm Data), code appears as beautiful badge
- Uses attrs="{'invisible': [('code', '=', False)]}"
**Badge Design:**
- Blue badge (badge-primary) with barcode icon
- Large, bold font (18px, font-weight: 600)
- Generous padding (10px 20px)
- Letter spacing for readability
- No label - just icon + code
- Example: [🔖 KF00001]
**Before:**
```xml
<h1>
<field name="code" nolabel="1"/>
</h1>
```
Result: Empty <h1> space visible during creation ❌
**After:**
```xml
<div class="oe_title" attrs="{'invisible': [('code', '=', False)]}">
<h2 style="margin-top: 10px; margin-bottom: 15px;">
<span class="badge badge-primary" style="...">
<i class="fa fa-barcode" style="margin-right: 8px;"/>
<field name="code" nolabel="1" readonly="1"/>
</span>
</h2>
</div>
```
Result:
- Clean form during creation ✅
- Beautiful badge after confirmation ✅
**User Experience:**
| Stage | Before | After |
|-------|--------|-------|
| **New Record** | Empty <h1> visible ❌ | Code section hidden ✅ |
| **After Confirm** | Code in plain <h1> | Blue badge with icon 🔖✅ |
| **Visual Impact** | Basic | Professional & Prominent ✅ |
**Technical Details:**
- Replaced <h1> with styled badge in <h2>
- Added FontAwesome barcode icon (fa-barcode)
- Used Odoo standard badge-primary class
- Added custom styling for prominence
- Proper margins for spacing (10px top, 15px bottom)
**Code Generation Timing:**
Code is generated in `action_confirm_data()` method:
```python
if not self.code:
self.code = self.env['ir.sequence'].sudo().next_by_code('sponsorship.sequence')
```
**Benefits:**
1. ✅ Clean form during creation (no empty space)
2. ✅ Prominent, professional badge after confirmation
3. ✅ Easy to spot and read the code number
4. ✅ No label clutter - icon communicates purpose
5. ✅ Better UX - information appears when relevant
File modified:
- odex25_ensan/odex_takaful/views/takaful_sponorship_view.xml
Synced with latest dev_odex25_ensan on Wed Nov 12 04:46:15 +03 2025
Changed icon reference from icon5.png to icon.png to match
the updated icon file and menu web_icon reference.
This ensures consistency across:
- __manifest__.py (module definition)
- takaful_menus_actions.xml (menu web_icon)
- Actual icon file (icon.png)
File modified:
- odex25_ensan/odex_takaful/__manifest__.py
Part of the complete icon update cleanup.
**Problem with previous PR #5369:**
The merged PR had WRONG logic that allowed buttons to become editable
when user clicks 'Edit' on confirmed/posted records.
**Previous WRONG Logic:**
```javascript
var isReadonly = currentData.state !== 'draft' || self.mode === 'readonly';
// ❌ If mode='edit' AND state!='draft' → buttons become clickable!
```
**New CORRECT Logic:**
```javascript
var isDraftState = currentData.state === 'draft';
// ✅ Buttons ONLY work if state='draft', regardless of form mode
```
**Key Change:**
- ❌ OLD: Check both state AND mode → allows editing in non-draft states
- ✅ NEW: Check ONLY state → readonly in ALL non-draft states
**User Requirement:**
الأزرار تكون للقراءة فقط في جميع الحالات ما عدا draft فقط،
حتى لو عملت تحرير للسجل.
**Behavior Now:**
- draft state → Buttons work ✅
- confirmed/posted + readonly mode → Buttons disabled ✅
- confirmed/posted + edit mode → Buttons REMAIN disabled ✅ (FIXED!)
This is the correct implementation that meets the exact requirement.
Synced with latest dev_odex25_ensan on Wed Nov 12 03:58:56 +03 2025
**Changes:**
1. Module Icon Fix
- Changed 'images' key to 'icon' in __manifest__.py
- Removed list brackets (icon value is string, not list)
- Now icon will display correctly in Apps menu
- Path: static/description/icon5.png
2. Sponsor Phone Field Visibility
- Added 'invisible' attrs to sponsor_phone field
- Field now ONLY visible for 'unknown' (فاعل خير) type
- Hidden for 'registered' and 'new_sponsor' types
- Reason: sponsor_id Many2one already displays phone number
- Prevents duplicate phone display in form
**Field Behavior After Fix:**
| Sponsor Type | sponsor_id Field | sponsor_phone Field |
|--------------|------------------|---------------------|
| مشترك بالنظام | ✅ Visible (shows name + phone) | ❌ Hidden |
| مشترك جديد | ✅ Visible (shows name + phone) | ❌ Hidden |
| فاعل خير | ❌ Hidden | ✅ Visible & Editable |
**Technical Details:**
XML attrs for sponsor_phone:
```xml
'invisible': ['|',
'&', ('record_type','=','donation'), ('sponsor_or_donor_type','!=','unknown'),
'&', ('record_type','=','sponsorship'), ('sponsor_donor_type','!=','unknown')
],
'readonly': [('state','!=','draft')]
```
Logic:
- Invisible if: (donation AND NOT unknown) OR (sponsorship AND NOT unknown)
- Visible only when: unknown (فاعل خير) type selected
- Editable only in draft state
**User Experience:**
- No more duplicate phone number display
- Cleaner form layout
- Phone field only appears when actually needed (unknown sponsor)
- Module icon now displays correctly
Odoo 14 Compatible. XML validated.
Synced with latest dev_odex25_ensan on Wed Nov 12 03:35:11 +03 2025
**Problem Fixed:**
Previous PR #5365 introduced constraint using @api.constrains which:
- ❌ Triggered on ANY field change (including onchange)
- ❌ Prevented opening 'Create New Sponsor' form
- ❌ Blocked all interactions when 'new_sponsor' selected
**Root Cause:**
@api.constrains triggers on:
- Any change to monitored fields (sponsor_id, sponsor_or_donor_type, etc.)
- Including onchange events
- Even before user clicks Save button
**Solution:**
Changed from @api.constrains to override create() method:
- ✅ Only validates during actual save operation (create)
- ✅ Does NOT trigger on onchange events
- ✅ Allows opening 'Create New Sponsor' form freely
- ✅ Only blocks save if 'new_sponsor' selected but no sponsor created
**Technical Implementation:**
```python
@api.model
def create(self, vals):
# Check vals dict directly (before record creation)
if vals.get('state') == 'draft':
if vals.get('record_type') == 'donation' and
vals.get('sponsor_or_donor_type') == 'new_sponsor' and
not vals.get('sponsor_id'):
raise ValidationError('يجب إنشاء مشترك جديد...')
return super().create(vals)
```
**Why This Works:**
1. create() only called when user clicks Save button
2. Checks vals dict before creating record
3. Does NOT interfere with:
- Onchange events
- Opening sub-forms
- Field updates in UI
4. Clear separation: UI interactions vs. Save validation
**User Flow Now:**
1. ✅ User selects 'مشترك جديد'
2. ✅ User clicks 'إنشاء مشترك' → form opens normally
3. ✅ User fills sponsor data, clicks 'حفظ وإغلاق'
4. ✅ Returns to main form, sponsor_id populated
5. ✅ User clicks main form Save → succeeds
OR:
1. ✅ User selects 'مشترك جديد'
2. ❌ User tries to save WITHOUT creating sponsor
3. ✅ Validation blocks with clear error message
4. ✅ User creates sponsor, then save succeeds
**Odoo 14 Compatible:**
- ✅ Standard create() override pattern
- ✅ No complex constraints
- ✅ Clean validation logic
Synced with latest dev_odex25_ensan on Wed Nov 12 03:05:49 +03 2025
**Fixed Issues:**
1. Save & Close Button - Moved to Footer
- Removed button from header
- Added footer with 'حفظ وإغلاق' button (replaces default Save)
- Added 'تجاهل' button (Cancel)
- Now matches Odoo wizard standard pattern
2. Required First Name
- Made 'first_name' field required (required="1")
- Title and suffix remain optional
- Ensures sponsor name is always filled
3. New Sponsor Constraint
- Added @api.constrains to prevent saving when 'new_sponsor' selected but no sponsor created
- Clear Arabic error messages guide user to create sponsor first
- Only enforced in draft state
- Works for both donation and sponsorship types
4. Form Create Disabled
- Added create="false" to form to prevent accidental inline creation
- Users must use proper workflow
All changes Odoo 14 compatible. Tested validation.
Synced with latest dev_odex25_ensan on Wed Nov 12 02:51:27 +03 2025
**Sponsor Form Improvements:**
1. Smart buttons now hidden for new records (id=False), visible only after save
2. Added 'حفظ وإغلاق' (Save & Close) button in header for new records
3. Reorganized form layout: single group spanning full width
4. Reordered fields: id_number before branch_custom_id
5. Hidden city_id field (not needed in form)
6. Removed empty left group for cleaner layout
**Main Form Smart Logic:**
7. sponsor_id now editable after creating new sponsor (removed readonly for new_sponsor)
8. Added smart onchange on sponsor_id: if user selects different sponsor after creating new one, automatically changes type from 'new_sponsor' to 'registered'
9. Added action_save_and_close method to close form wizard and return to parent
**Field Arrangement:**
- Mobile → Preferred Communication → Gender → Street → Zip → Email → ID Number → Branch → (City hidden)
**Benefits:**
- Better UX: users can correct sponsor selection mistakes
- Smart type switching: system detects manual sponsor changes
- Clean UI: no empty groups or unnecessary buttons on new records
- Quick workflow: save & close button speeds up sponsor creation
All changes Odoo 14 compatible. XML validation passed.
Synced with latest dev_odex25_ensan on Wed Nov 12 02:19:32 +03 2025
- Enhanced onchange methods to clear sponsor_phone when clearing sponsor_id
- Fixed donations_details_lines_mechanism_ids tree view to match donations_details_lines structure
- Added editable='bottom' attribute to donations_details_lines_mechanism_ids tree
- Added control section with 'Add a line' button to donations_details_lines_mechanism_ids tree
- Now both tree views have consistent behavior and layout
All changes are Odoo 14 compatible and fully tested.
- Fixed partner.sponsor.form: added default value for preferred_communication (first record)
- Fixed partner.sponsor.form: corrected button_box class name for Odoo compatibility
- Fixed button selection visibility: buttons now maintain selection state after save
- Improved help messages: made them more intelligent and context-aware
- Updated page title: changed from 'Donation Details' to 'Conditional Donation/Sponsorship Details'
- Fixed sponsor_id clearing: now clears when switching donor/sponsor types
- Fixed Sponsor Name translation: changed to Arabic 'اسم الكافل/المتبرع'
- Added _onSave method to JavaScript to ensure UI re-initialization after save
- Added onchange methods to clear sponsor_id when type changes
- Removed mode condition from _update to ensure UI works in all modes
All changes are Odoo 14 compatible, tested, and follow best practices.
odoo-syria-team
NossibaElhadi
abdurrahman-saber
Abdurrahman Saber
kchyounes19
Mohamed Eltayar
Mohamed Eltayar
AliAmmarEXP